Skip to content

Commit

Permalink
chore(kongstate) discard logger argument
Browse files Browse the repository at this point in the history
Discard the logger argument to kongstate.FillConsumersAndCredentials().
It is not currently used, but removing it from the signature would
require a breaking change, with a decent chance we'd re-add it in the
future.
  • Loading branch information
rainest committed Apr 15, 2024
1 parent 60f790f commit 56d527c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion internal/dataplane/kongstate/kongstate.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ func (ks *KongState) SanitizedCopy() *KongState {
}

func (ks *KongState) FillConsumersAndCredentials(
logger logr.Logger,
_ logr.Logger,
s store.Storer,
failuresCollector *failures.ResourceFailuresCollector,
) {
Expand Down
1 change: 0 additions & 1 deletion test/envtest/admission_webhook_envtest_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,6 @@ func TestAdmissionWebhook_KongConsumers(t *testing.T) {
},
},
StringData: map[string]string{

"username": "electron",
"password": "testpass",
},
Expand Down

0 comments on commit 56d527c

Please sign in to comment.