Skip to content

Commit

Permalink
Replace hardcoding with defined variables.
Browse files Browse the repository at this point in the history
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
  • Loading branch information
tao12345666333 committed Apr 17, 2024
1 parent 8de5e47 commit 70caa7c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/conformance/gateway_conformance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ var traditionalRoutesSupportedFeatures = []suite.SupportedFeature{
suite.SupportHTTPRoute,
// extended features
suite.SupportHTTPRouteResponseHeaderModification,
// TODO: https://github.com/Kong/kubernetes-ingress-controller/issues/5868
// Temporarily disabled and tracking through the following issue.
// https://github.com/Kong/kubernetes-ingress-controller/issues/5868
// suite.SupportHTTPRouteBackendTimeout,
}

Expand All @@ -44,8 +44,8 @@ var expressionRoutesSupportedFeatures = []suite.SupportedFeature{
suite.SupportHTTPRouteQueryParamMatching,
suite.SupportHTTPRouteMethodMatching,
suite.SupportHTTPRouteResponseHeaderModification,
// TODO: https://github.com/Kong/kubernetes-ingress-controller/issues/5868
// Temporarily disabled and tracking through the following issue.
// https://github.com/Kong/kubernetes-ingress-controller/issues/5868
// suite.SupportHTTPRouteBackendTimeout,
}

Expand All @@ -63,10 +63,10 @@ func TestGatewayConformance(t *testing.T) {
case dpconf.RouterFlavorTraditionalCompatible:
skippedTests = skippedTestsForTraditionalRoutes
supportedFeatures = traditionalRoutesSupportedFeatures
mode = "traditional-compatible"
mode = dpconf.RouterFlavorTraditionalCompatible

Check failure on line 66 in test/conformance/gateway_conformance_test.go

View workflow job for this annotation

GitHub Actions / linters / lint

cannot use dpconf.RouterFlavorTraditionalCompatible (constant "traditional_compatible" of type "github.com/kong/kubernetes-ingress-controller/v3/internal/dataplane/config".RouterFlavor) as string value in assignment

Check failure on line 66 in test/conformance/gateway_conformance_test.go

View workflow job for this annotation

GitHub Actions / conformance-tests / traditional-compatible-router

cannot use dpconf.RouterFlavorTraditionalCompatible (constant "traditional_compatible" of type "github.com/kong/kubernetes-ingress-controller/v3/internal/dataplane/config".RouterFlavor) as string value in assignment

Check failure on line 66 in test/conformance/gateway_conformance_test.go

View workflow job for this annotation

GitHub Actions / conformance-tests / expressions-router

cannot use dpconf.RouterFlavorTraditionalCompatible (constant "traditional_compatible" of type "github.com/kong/kubernetes-ingress-controller/v3/internal/dataplane/config".RouterFlavor) as string value in assignment
case dpconf.RouterFlavorExpressions:
supportedFeatures = expressionRoutesSupportedFeatures
mode = "expressions"
mode = dpconf.RouterFlavorExpressions

Check failure on line 69 in test/conformance/gateway_conformance_test.go

View workflow job for this annotation

GitHub Actions / linters / lint

cannot use dpconf.RouterFlavorExpressions (constant "expressions" of type "github.com/kong/kubernetes-ingress-controller/v3/internal/dataplane/config".RouterFlavor) as string value in assignment (typecheck)

Check failure on line 69 in test/conformance/gateway_conformance_test.go

View workflow job for this annotation

GitHub Actions / conformance-tests / traditional-compatible-router

cannot use dpconf.RouterFlavorExpressions (constant "expressions" of type "github.com/kong/kubernetes-ingress-controller/v3/internal/dataplane/config".RouterFlavor) as string value in assignment

Check failure on line 69 in test/conformance/gateway_conformance_test.go

View workflow job for this annotation

GitHub Actions / conformance-tests / expressions-router

cannot use dpconf.RouterFlavorExpressions (constant "expressions" of type "github.com/kong/kubernetes-ingress-controller/v3/internal/dataplane/config".RouterFlavor) as string value in assignment
default:
t.Fatalf("unsupported KongRouterFlavor: %s", rf)
}
Expand Down

0 comments on commit 70caa7c

Please sign in to comment.