Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
  • Loading branch information
tao12345666333 and pmalek committed Jun 5, 2024
1 parent 0518637 commit 9455464
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ Adding a new version? You'll need three changes:
enabling the filter is recommended as soon as is convenient.
[#5856](https://github.com/Kong/kubernetes-ingress-controller/pull/5856)
- Dynamically set the proxy protocol of GRPCRoute to `grpc` or `grpcs` based on the port listened by Gateway.
If you don't set the protocol for Service via "konghq.com/protocol" annotation, Kong will use `grpc` instead of `grpcs`.
If you don't set the protocol for Service via `konghq.com/protocol` annotation, Kong will use `grpc` instead of `grpcs`.
[#5776](https://github.com/Kong/kubernetes-ingress-controller/pull/5776)
- The `/debug/config/failed` and `/debug/config/successful` diagnostic
endpoints now nest configuration dumps under a `config` key. These endpoints
Expand Down
4 changes: 2 additions & 2 deletions test/conformance/gateway_conformance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ var skippedTestsForTraditionalRoutes = []string{
}

var skippedTestsForExpressionRoutes = []string{
// When processingvthis scenario,
// the expression router of Kong currently needs to add `priority` to the route.
// When processing this scenario, the Kong's expression router currently needs to
// add `priority` to the route.
tests.GRPCRouteListenerHostnameMatching.ShortName,
}

Expand Down

0 comments on commit 9455464

Please sign in to comment.