Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): don't test istio against k8s v1.26 #3280

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

According to Istio's support status, Kubernetes v1.26 isn't supported by any Istio version.

Which issue this PR fixes:

Part of #3199

@czeslavo czeslavo requested a review from a team as a code owner December 19, 2022 11:19
@czeslavo czeslavo changed the title chore(ci): don't test istio against k8s v1.26.0 chore(ci): don't test istio against k8s v1.26 Dec 19, 2022
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://istio.io/latest/docs/releases/supported-releases/
I think k8s 1.25 is not officially supported by istio 1.14 and earlier.

@czeslavo
Copy link
Contributor Author

https://istio.io/latest/docs/releases/supported-releases/ I think k8s 1.25 is not officially supported by istio 1.14 and earlier.

Yeah, but I think as long as our tests pass in this configuration, we're ok, aren't we?

@czeslavo czeslavo enabled auto-merge (squash) December 19, 2022 11:38
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 74.1% // Head: 74.0% // Decreases project coverage by -0.0% ⚠️

Coverage data is based on head (0928973) compared to base (48f4d7a).
Patch has no changes to coverable lines.

❗ Current head 0928973 differs from pull request most recent head 886310d. Consider uploading reports for the commit 886310d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3280     +/-   ##
=======================================
- Coverage   74.1%   74.0%   -0.1%     
=======================================
  Files        111     111             
  Lines      13275   13275             
=======================================
- Hits        9847    9834     -13     
- Misses      2801    2810      +9     
- Partials     627     631      +4     
Impacted Files Coverage Δ
...ternal/controllers/gateway/httproute_controller.go 52.5% <0.0%> (-1.7%) ⬇️
internal/dataplane/parser/parser.go 89.7% <0.0%> (-1.7%) ⬇️
internal/dataplane/kongstate/service.go 67.3% <0.0%> (+1.2%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo merged commit e0a6e3f into main Dec 19, 2022
@czeslavo czeslavo deleted the chore/istio-k8s-dep branch December 19, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants