Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix release tests command #3285

Merged
merged 2 commits into from
Dec 19, 2022
Merged

chore(ci): fix release tests command #3285

merged 2 commits into from
Dec 19, 2022

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Dec 19, 2022

What this PR does / why we need it:

When switching to running E2E tests instead of integration tests as the release gate, we missed adjusting commands properly: c6344be

Failing job: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/3732606321/jobs/6333473197

Which issue this PR fixes:

Part of #3199

@czeslavo czeslavo self-assigned this Dec 19, 2022
@czeslavo czeslavo requested a review from a team as a code owner December 19, 2022 16:19
@czeslavo czeslavo added this to the KIC v2.8.0 milestone Dec 19, 2022
pmalek
pmalek previously approved these changes Dec 19, 2022
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@czeslavo czeslavo enabled auto-merge (squash) December 19, 2022 16:29
@czeslavo czeslavo added the do not merge let the author merge this, don't merge for them. label Dec 19, 2022
@czeslavo
Copy link
Contributor Author

@pmalek I've noticed one more issue, PTAL: 9fb30c1

@czeslavo czeslavo requested a review from pmalek December 19, 2022 16:40
@czeslavo czeslavo removed the do not merge let the author merge this, don't merge for them. label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 74.0% // Head: 74.1% // Increases project coverage by +0.0% 🎉

Coverage data is based on head (9fb30c1) compared to base (38b801f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3285   +/-   ##
=====================================
  Coverage   74.0%   74.1%           
=====================================
  Files        111     111           
  Lines      13275   13285   +10     
=====================================
+ Hits        9836    9851   +15     
+ Misses      2810    2808    -2     
+ Partials     629     626    -3     
Impacted Files Coverage Δ
...nal/controllers/gateway/gatewayclass_controller.go 79.1% <0.0%> (-4.7%) ⬇️
internal/controllers/gateway/gateway_controller.go 68.7% <0.0%> (-1.7%) ⬇️
internal/controllers/reference/reference.go 41.0% <0.0%> (-0.8%) ⬇️
internal/dataplane/parser/wrappers_backendref.go 87.2% <0.0%> (-0.2%) ⬇️
internal/dataplane/parser/translate_knative.go 88.5% <0.0%> (-0.1%) ⬇️
internal/meshdetect/detector.go 79.4% <0.0%> (-0.1%) ⬇️
internal/dataplane/parser/translate_httproute.go 90.0% <0.0%> (-0.1%) ⬇️
internal/dataplane/kongstate/route.go 92.5% <0.0%> (-0.1%) ⬇️
internal/dataplane/kong_client.go 85.1% <0.0%> (ø)
internal/controllers/gateway/route_utils.go 76.2% <0.0%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo enabled auto-merge (squash) December 19, 2022 17:00
@czeslavo czeslavo requested a review from a team December 19, 2022 17:01
@czeslavo czeslavo merged commit 37c9504 into main Dec 19, 2022
@czeslavo czeslavo deleted the chore/fix-release-job branch December 19, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants