Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix KONG_CLUSTER_VERSION in test-previous-kubernetes #3286

Closed
wants to merge 1 commit into from
Closed

chore(ci): fix KONG_CLUSTER_VERSION in test-previous-kubernetes #3286

wants to merge 1 commit into from

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Dec 19, 2022 •
edited

What this PR does / why we need it:

KONG_CLUSTER_VERSION is expected to be in vMajor.Minor.Patch format:

kubernetes-ingress-controller/hack/e2e/cluster/deploy/main.go

Line 32 in c6344be

k8sVersion = semver.MustParse(strings.TrimPrefix(os.Getenv(k8sVersionVar), "v"))

Failing job: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/3733633765/jobs/6335083354

Which issue this PR fixes:

Part of #3199

@czeslavo czeslavo requested a review from a team as a code owner December 19, 2022 17:48
@czeslavo czeslavo self-assigned this Dec 19, 2022
@czeslavo czeslavo added this to the KIC v2.8.0 milestone Dec 19, 2022
pmalek
pmalek approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to a relevant failure in CI ?

@czeslavo
Copy link
Contributor Author

Can you link to a relevant failure in CI ?

Yup, I've just did :)

@czeslavo czeslavo enabled auto-merge (squash) December 19, 2022 17:52
@czeslavo czeslavo mentioned this pull request Dec 19, 2022
Merged
@czeslavo
Copy link
Contributor Author

Closing in favor of #3287

@czeslavo czeslavo closed this Dec 19, 2022
@czeslavo czeslavo deleted the chore/prev-k8s-test-version branch February 13, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

@rainest rainest Awaiting requested review from rainest

Assignees

@czeslavo czeslavo

Labels
area/ci size/XS
Projects
None yet
Milestone
KIC v2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@czeslavo @pmalek