Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): align docs workflow #3295

Merged
merged 4 commits into from
Dec 21, 2022
Merged

chore(ci): align docs workflow #3295

merged 4 commits into from
Dec 21, 2022

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

As a follow-up to #3199:

  • make the job an initial step of creating a PR for the release
  • add a version as an input and use it to name the generated reference accordingly

Related to: #3294

Which issue this PR fixes:

Part of https://github.com/Kong/team-k8s/issues/267.

@czeslavo czeslavo self-assigned this Dec 20, 2022
@czeslavo czeslavo force-pushed the chore/release-docs-workflow branch 3 times, most recently from 25c2239 to 4046c90 Compare December 20, 2022 17:06
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 74.0% // Head: 74.0% // Decreases project coverage by -0.0% ⚠️

Coverage data is based on head (3bc6bb6) compared to base (e0cec98).
Patch has no changes to coverable lines.

❗ Current head 3bc6bb6 differs from pull request most recent head 145661d. Consider uploading reports for the commit 145661d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3295     +/-   ##
=======================================
- Coverage   74.0%   74.0%   -0.1%     
=======================================
  Files        111     111             
  Lines      13285   13285             
=======================================
- Hits        9841    9840      -1     
- Misses      2817    2818      +1     
  Partials     627     627             
Impacted Files Coverage Δ
internal/dataplane/parser/parser.go 89.0% <0.0%> (-0.7%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 54.2% <0.0%> (ø)
internal/dataplane/kongstate/service.go 67.3% <0.0%> (+1.2%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czeslavo czeslavo force-pushed the chore/release-docs-workflow branch 2 times, most recently from 4a25800 to 3bc6bb6 Compare December 20, 2022 17:25
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 20, 2022
@czeslavo czeslavo marked this pull request as ready for review December 20, 2022 17:31
@czeslavo czeslavo requested a review from a team as a code owner December 20, 2022 17:31
@rainest
Copy link
Contributor

rainest commented Dec 20, 2022

Is there a way to dry-run this in forks first to confirm functionality and feel? May be a bit annoying with the multiple repos involved, but it should be possible to set up a personal KIC and docs fork and demo the release docgen/PR process with that.

@czeslavo
Copy link
Contributor Author

Is there a way to dry-run this in forks first to confirm functionality and feel? May be a bit annoying with the multiple repos involved, but it should be possible to set up a personal KIC and docs fork and demo the release docgen/PR process with that.

Here's a PR that was created by running gh workflow run release_docs.yaml --ref chore/release-docs-workflow -f tag=v2.8.0: Kong/docs.konghq.com#4950

Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good, just one minor addition since it doesn't (and probably can't) update the nav manifest to point to it.

.github/ISSUE_TEMPLATE/release.yaml Outdated Show resolved Hide resolved
Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com>
@rainest rainest enabled auto-merge (squash) December 21, 2022 21:50
@rainest rainest merged commit 52b94d2 into main Dec 21, 2022
@rainest rainest deleted the chore/release-docs-workflow branch December 21, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants