-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translate grpcroute to expression based routes #3988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
added
area/feature
New feature or request
work in progress
Work In Progress
area/gateway-api
Relating to upstream Kubernetes SIG Networking Gateway API
labels
May 11, 2023
randmonkey
force-pushed
the
feat/translate_grpc_route
branch
from
May 11, 2023 03:59
6a549d3
to
95244b4
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3988 +/- ##
=======================================
+ Coverage 58.8% 59.5% +0.7%
=======================================
Files 142 145 +3
Lines 15996 16125 +129
=======================================
+ Hits 9410 9603 +193
+ Misses 5955 5889 -66
- Partials 631 633 +2
☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
feat/translate_grpc_route
branch
from
May 11, 2023 07:53
95244b4
to
871493d
Compare
czeslavo
reviewed
May 11, 2023
randmonkey
force-pushed
the
feat/translate_grpc_route
branch
2 times, most recently
from
May 12, 2023 06:22
eff674f
to
66b4dac
Compare
czeslavo
approved these changes
May 12, 2023
randmonkey
force-pushed
the
feat/translate_grpc_route
branch
from
May 15, 2023 03:07
66b4dac
to
3696668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/feature
New feature or request
area/gateway-api
Relating to upstream Kubernetes SIG Networking Gateway API
size/XXL
work in progress
Work In Progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
translate
GRPCRoute
to expression based kong routes.Which issue this PR fixes:
fixes #3752
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR