Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): adjust golangci-lint config, fix reported #4451

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

Remove redundant configuration for skip-dirs from .golangci.yaml. It's not needed since auto-generated Go code is marked with comments and omitted by golangci-lint. Furthermore, this redundant config leads to omitting files that should be checked.

Special notes for your reviewer:

Adding a dot in pkg/apis/configuration/v1/conditions.go is questionable, but let's do it to satisfy the linter, it doesn't make "serious harm".

@programmer04 programmer04 added area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Aug 3, 2023
@programmer04 programmer04 self-assigned this Aug 3, 2023
@programmer04 programmer04 requested a review from a team as a code owner August 3, 2023 15:11
@programmer04 programmer04 enabled auto-merge (squash) August 3, 2023 15:13
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 55.5% and no project coverage change.

Comparison is base (f6de833) 67.5% compared to head (60f2639) 67.5%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4451   +/-   ##
=====================================
  Coverage   67.5%   67.5%           
=====================================
  Files        160     160           
  Lines      18803   18804    +1     
=====================================
+ Hits       12704   12705    +1     
  Misses      5337    5337           
  Partials     762     762           
Files Changed Coverage Δ
internal/dataplane/configfetcher/config_fetcher.go 78.5% <ø> (ø)
internal/dataplane/kongstate/consumer.go 100.0% <ø> (ø)
internal/dataplane/parser/translators/ingress.go 93.8% <ø> (ø)
...al/dataplane/sendconfig/inmemory_error_handling.go 58.9% <0.0%> (-0.9%) ⬇️
internal/manager/scheme/scheme.go 22.5% <0.0%> (ø)
internal/store/fake_store.go 39.6% <0.0%> (ø)
internal/admission/handler.go 35.2% <50.0%> (ø)
internal/dataplane/kongstate/route.go 90.9% <100.0%> (ø)
internal/dataplane/kongstate/service.go 46.7% <100.0%> (ø)
internal/dataplane/kongstate/upstream.go 63.5% <100.0%> (ø)
... and 6 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 merged commit 7e567cc into main Aug 3, 2023
50 checks passed
@programmer04 programmer04 deleted the adjust-golangci-lint branch August 3, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants