-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TCPIngress and UDPIngress expression routes #4612
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4612 +/- ##
=======================================
- Coverage 68.2% 68.0% -0.3%
=======================================
Files 162 163 +1
Lines 19008 19091 +83
=======================================
+ Hits 12973 12983 +10
- Misses 5274 5339 +65
- Partials 761 769 +8
☔ View full report in Codecov by Sentry. |
Add support for the expression router to TCPIngress and UDPIngress.
5b74f9d
to
a728d06
Compare
My question about the use of the |
0d1dc6b
to
375f3b9
Compare
|
What this PR does / why we need it:
Adds expression routing for TCPIngress and UDPIngress.
Adds a unit test for the L4 kongstate.Route translator.
Which issue this PR fixes:
Fix #4541
Fix #4542
Special notes for your reviewer:
#4385 is still setting the traditional
protocols
field. Is this correct? https://docs.konghq.com/gateway/latest/reference/router-expressions-language/#main indicates there's anet.protocol
expression field.#4385 added a test for TCPRoute specifically, but I don't think we need a per-resource unit test for these. We already test kongstate.Route creation for resources, and the expression translator operates on kongstate.Routes, so I think we can just test it on those directly.
Kong L4 routes support several features that our CRs and GWAPI Routes do not:
This is the intended feature set of GWAPI L4 Routes. We never added support for the complete set of Kong route capabilities to TCPIngress and UDPIngress, and there is apparently limited demand for the missing functionality (I don't know of any outstanding requests for it). The TCPIngress and UDPIngress feature set is coincidentally the same as what GWAPI Routes can support. As this additional functionality isn't supported by the resources, I didn't add support in the translator, just a comment noting the gap.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR