Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use restricted GITHUB_TOKEN istead of GITHUB PAT for issue state check #5081

Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Nov 3, 2023

What this PR does / why we need it:

Limit the scope of the GITHUB_TOKEN used in issue status check to issues read-only.
Ref: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

Example workflow run: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6746666425

@pmalek pmalek added the area/ci label Nov 3, 2023
@pmalek pmalek self-assigned this Nov 3, 2023
@pmalek pmalek marked this pull request as ready for review November 3, 2023 14:51
@pmalek pmalek requested a review from a team as a code owner November 3, 2023 14:51
@pmalek pmalek enabled auto-merge (squash) November 3, 2023 14:51
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a364f35) 75.4% compared to head (c6122c9) 75.5%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5081     +/-   ##
=======================================
+ Coverage   75.4%   75.5%   +0.1%     
=======================================
  Files        167     167             
  Lines      18911   18911             
=======================================
+ Hits       14275   14294     +19     
+ Misses      3806    3792     -14     
+ Partials     830     825      -5     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek merged commit c1ff7da into main Nov 3, 2023
56 checks passed
@pmalek pmalek deleted the use-restricted-github-token-in-issue-checking-workflow branch November 3, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants