Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport(v2.12.x): fix(tests): skip upgrade tests if not upgrading between two consecuti… #5365

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

tao12345666333
Copy link
Member

…ve Kong versions (#5327)

(cherry picked from commit 614c6c0)

What this PR does / why we need it:
#5257 (comment)

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@tao12345666333 tao12345666333 requested a review from a team as a code owner December 19, 2023 10:05
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b929f67) 68.0% compared to head (01ac100) 68.0%.
Report is 3 commits behind head on release/2.12.x.

Files Patch % Lines
internal/manager/run.go 44.4% 4 Missing and 1 partial ⚠️
internal/dataplane/deckgen/generate.go 66.6% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/2.12.x   #5365     +/-   ##
================================================
- Coverage            68.0%   68.0%   -0.1%     
================================================
  Files                 165     165             
  Lines               19344   19352      +8     
================================================
+ Hits                13159   13163      +4     
- Misses               5397    5401      +4     
  Partials              788     788             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit wrt the PR: I'd suggest to include the target version (or branch) in the PR title so that it's obvious when looking at the PR list what this PR tried to achieve.

Ideally we'd also add this issue into the respective Milestone but that's minor thing.

@tao12345666333 tao12345666333 added this to the KIC v2.12.x milestone Dec 19, 2023
@tao12345666333 tao12345666333 changed the title Backport: fix(tests): skip upgrade tests if not upgrading between two consecuti… Backport(v2.12.x): fix(tests): skip upgrade tests if not upgrading between two consecuti… Dec 19, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based and GKE-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7261609627

@tao12345666333 tao12345666333 merged commit 4f025c4 into release/2.12.x Dec 19, 2023
200 of 215 checks passed
@tao12345666333 tao12345666333 deleted the backport-5327-to-release/2.12.x branch December 19, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants