feat: implement KongLicense controller and inject to translator #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
added
area/feature
randmonkey
removed
the
area/kong
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5514 +/- ##
=======================================
- Coverage 71.8% 71.2% -0.6%
=======================================
Files 176 177 +1
Lines 18085 18301 +216
=======================================
+ Hits 12986 13042 +56
- Misses 4157 4306 +149
- Partials 942 953 +11 ☔ View full report in Codecov by Sentry. |
randmonkey
force-pushed
the
feat/kong_license_controller
branch
3 times, most recently
from
def8fad
to
602546f
Compare
randmonkey
force-pushed
the
feat/kong_license_controller
branch
from
602546f
to
ee4f248
Compare
randmonkey
changed the title
randmonkey
force-pushed
the
feat/kong_license_controller
branch
from
c37ef6c
to
2c2138a
Compare
czeslavo
reviewed
Feb 2, 2024
czeslavo
reviewed
Feb 2, 2024
|
BTW it might make sense to not include integration tests and translator code in this PR to not make it bigger as it's already 2k+ lines. :) |
czeslavo
reviewed
Feb 5, 2024
czeslavo
reviewed
Feb 5, 2024
czeslavo
reviewed
Feb 5, 2024
Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com>
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7795253842 |
czeslavo
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR implements a
KongLicensecontroller which picks the newestKongLicensein the cluster and provides aGetLicensemethod for translator to inject Kong license into Kong configurations.The controller is enabled when
--enable-controller-kong-licenseis set totrue(by default) and sync license with Konnect disabled. When sync license with Konnect is enabled, the licenses from Konnect takes the precedence.Which issue this PR fixes:
Major part of #5437.
Special notes for your reviewer:
Not fully finished yet, but can reconcile
KongLicenseresources and ready to receive some reviews. Major remaining part:KongLicenseCRD in cluster, the controller will exit abnormallyKongLicense?PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR