Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set timeout for e2e test and perf test #5786

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Apr 2, 2024

What this PR does / why we need it:

As we have already set a timeout for ORG, any job that does not specify its timeout will default to using the global 10 minutes.

Company wide vars.GHA_DEFAULT_TIMEOUT = 10 minutes for our use-case repo wide vars.GHA_EXTENDED_TIMEOUT_MINUTES = 30 minutes was defined too

The e2e tests and performance tests running on GKE took more than 10 minutes, so I have set them to run for 30 minutes.

e2e-tests / gke (1.29.2, TestDeployAllInOnePostgresGatewayDiscovery$)
The job running on runner GitHub Actions 30 has exceeded the maximum execution time of 10 minutes.

ref: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8517470363

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@tao12345666333 tao12345666333 requested a review from a team as a code owner April 2, 2024 07:27
@tao12345666333 tao12345666333 self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9%. Comparing base (d82716c) to head (a75def8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5786     +/-   ##
=======================================
- Coverage   73.9%   73.9%   -0.1%     
=======================================
  Files        176     176             
  Lines      18187   18187             
=======================================
- Hits       13456   13441     -15     
- Misses      3734    3749     +15     
  Partials     997     997             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@randmonkey randmonkey merged commit 0b19d87 into main Apr 2, 2024
105 checks passed
@randmonkey randmonkey deleted the ci-fix-timeout branch April 2, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants