-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: set timeout for e2e test and perf test #5786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5786 +/- ##
=======================================
- Coverage 73.9% 73.9% -0.1%
=======================================
Files 176 176
Lines 18187 18187
=======================================
- Hits 13456 13441 -15
- Misses 3734 3749 +15
Partials 997 997 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
force-pushed
the
ci-fix-timeout
branch
from
April 2, 2024 08:01
2c5fd0c
to
a75def8
Compare
randmonkey
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As we have already set a timeout for ORG, any job that does not specify its timeout will default to using the global 10 minutes.Company wide vars.GHA_DEFAULT_TIMEOUT = 10 minutes for our use-case repo wide vars.GHA_EXTENDED_TIMEOUT_MINUTES = 30 minutes was defined too
The e2e tests and performance tests running on GKE took more than 10 minutes, so I have set them to run for 30 minutes.
ref: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8517470363
Which issue this PR fixes:
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:- [ ] theCHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR