-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix feature gates used in TestDeployAllInOneDBLESSGateway #5832
Conversation
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8603061554 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5832 +/- ##
=======================================
+ Coverage 73.2% 73.9% +0.6%
=======================================
Files 176 176
Lines 18194 18194
=======================================
+ Hits 13332 13458 +126
+ Misses 3882 3735 -147
- Partials 980 1001 +21 ☔ View full report in Codecov by Sentry. |
This seems to fix the issue. The 2 failures in https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8603061554/attempts/1 come from #5828 |
(cherry picked from commit 5701912)
What this PR does / why we need it:
TestDeployAllInOneDBLESSGateway
performs an update and sets KIC's feature gates totestenv.GetFeatureGates()
which by default include theKongServiceFacade=true
kubernetes-ingress-controller/test/consts/feature_gates.go
Lines 7 to 8 in 96941c3
This is problematic because
KongServiceFacade
CRD is not installed by default and the controller which watches it doesn't have a fallback mechanism and just fails to start when the aforementioned CRD is missingkubernetes-ingress-controller/internal/controllers/configuration/kongupstreampolicy_controller.go
Lines 155 to 164 in 30a2991
This results in
This PR fixes that by setting the feature gates in the test to only enable the Gateway API alpha features.