Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(creds) remove kongCredType field support #5856

Merged
merged 10 commits into from
Apr 26, 2024
Merged

feat(creds) remove kongCredType field support #5856

merged 10 commits into from
Apr 26, 2024

Commits on Apr 23, 2024

  1. feat(creds) remove kongCredType field support 

    Remove support for the kongCredType field in credential Secrets. Only
honor the konghq.com/credential label.

Add a konghq.com/plugin-config label. This label indicates that a Secret
contains plugin configuration and should be validated against its
referrers when updated.

Add objectSelectors to the Secret blocks in the admission webhook
definition. Admission will skip any Secrets without a label indicating
they should be used by KIC.
    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    82c35ff View commit details
    Browse the repository at this point in the history

  2. chore(tests) use labels only for credential tests

    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    786695a View commit details
    Browse the repository at this point in the history

  3. feat(labels) add generic validate label

    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d312e89 View commit details
    Browse the repository at this point in the history

  4. feat(labels) add generic validate label

    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    96ad7b7 View commit details
    Browse the repository at this point in the history

  5. chore(kongstate) discard logger argument 

    Discard the logger argument to kongstate.FillConsumersAndCredentials().
It is not currently used, but removing it from the signature would
require a breaking change, with a decent chance we'd re-add it in the
future.
    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a97f933 View commit details
    Browse the repository at this point in the history

  6. chore(docs) add changelog entry for #5856

    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    027c04d View commit details
    Browse the repository at this point in the history

  7. chore(config) use a patch to add Secret hooks 

    Split the webhook manifest into the generated manifest and additional
rule patches. Kubebuilder limitations require writing your own rules to
use objectSelectors.

Remove the kubebuilder Secret hook generation directive and document the
workaround.

Refactor the envtest runner to build a webhook manifest via Kustomize,
rather than reading a static manifest.
    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    eaa3c04 View commit details
    Browse the repository at this point in the history

  8. feat(admission) warn on unlabeled Secrets

    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3097716 View commit details
    Browse the repository at this point in the history

  9. chore(tests) test no-filter webhook

    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ca1eb53 View commit details
    Browse the repository at this point in the history

  10. pr: remove Secret hook switch

    @rainest
    rainest committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    06ed355 View commit details
    Browse the repository at this point in the history