[Backport release/3.0.x] test(e2e): set appProtocol to HTTP for kuma tests #5951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set appProtocol to HTTP for kuma tests * Update test/e2e/helpers_test.go Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> --------- Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> (cherry picked from commit 72cb3b1)
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8876262263 |
czeslavo
approved these changes
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/3.0.x #5951 +/- ##
===============================================
Coverage ? 75.5%
===============================================
Files ? 167
Lines ? 18928
Branches ? 0
===============================================
Hits ? 14300
Misses ? 3798
Partials ? 830 ☔ View full report in Codecov by Sentry. |
|
Looks like backporting this does not fix the kuma tests https://github.com/Kong/kubernetes-ingress-controller/actions/runs/8876262263 |
randmonkey
added
do not merge
programmer04
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 72cb3b1 from #5507.