chore: make config/webhook to not store the resultant (incomplete) ValidatingWebhookConfiguration
#6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
complete-webhook-config
branch
from
a436ec1
to
1bf0dc4
Compare
czeslavo
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Because controller-tools does not allow using
objectSelectorcode markers (ref: kubernetes-sigs/controller-tools#553) we need to use kustomize patches to provide the fullValidatingWebhookConfigurationconfig: https://github.com/Kong/kubernetes-ingress-controller/blob/b01456169cbcfabd8684bef9e162fdcee4386196/config/webhook/additional_secret_hooks.yamlThis PR makes it so that we do not store an incomplete VWC config in
config/webhook/manifests.yamlwhich could be used by users. It is not stored inconfig/webhook/base/manifests.yamlto indicate that it shouldn't be used as it's just a part of the kustomize build.