Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport(2.12.x): fix: Re-fill client certificates of services after merging certificate (#6228) #6232

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jun 24, 2024

(cherry picked from commit d410be4)

What this PR does / why we need it:

Backport the fix of #6223 (PR #6228) to KIC 2.12.x.

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner June 24, 2024 06:02
@randmonkey randmonkey force-pushed the backport-6228-to-release/2.12.x branch from d201e6c to 2514b8d Compare June 24, 2024 06:19
@randmonkey randmonkey changed the title fix(translator): Re-fill client certificates of services after mergin… backport(2.12.x): fix: Re-fill client certificates of services after merging certificate (#6228) Jun 24, 2024
@randmonkey randmonkey mentioned this pull request Jun 24, 2024
32 tasks
@randmonkey randmonkey force-pushed the backport-6228-to-release/2.12.x branch from 2514b8d to 3c16624 Compare June 24, 2024 07:41
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.0%. Comparing base (b929f67) to head (cbef288).
Report is 9 commits behind head on release/2.12.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/2.12.x   #6232   +/-   ##
==============================================
  Coverage            68.0%   68.0%           
==============================================
  Files                 165     165           
  Lines               19344   19373   +29     
==============================================
+ Hits                13159   13192   +33     
  Misses               5397    5397           
+ Partials              788     784    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey force-pushed the backport-6228-to-release/2.12.x branch from 3c16624 to cbef288 Compare June 24, 2024 07:42
@randmonkey randmonkey changed the title backport(2.12.x): fix: Re-fill client certificates of services after merging certificate (#6228) backport(2.12.x): fix: Re-fill client certificates of services after merging certificate ([#6228](https://github.com/Kong/kubernetes-ingress-controller/pull/6228)) Jun 24, 2024
@randmonkey randmonkey changed the title backport(2.12.x): fix: Re-fill client certificates of services after merging certificate ([#6228](https://github.com/Kong/kubernetes-ingress-controller/pull/6228)) backport(2.12.x): fix: Re-fill client certificates of services after merging certificate (#6228) Jun 24, 2024
@tao12345666333 tao12345666333 added the ci/run-e2e Trigger e2e test run from PR label Jun 24, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/9642302005

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Jun 24, 2024
@randmonkey randmonkey merged commit 5112c43 into release/2.12.x Jun 24, 2024
191 checks passed
@randmonkey randmonkey deleted the backport-6228-to-release/2.12.x branch June 24, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants