Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom_entity) support cross-namespace reference for KongCustomEntity #6289

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented Jul 4, 2024

What this PR does / why we need it:

Allow KongCustomEntity to refer to KongPlugin in another namespace if ReferenceGrant allows.

Which issue this PR fixes:

fixes #6288
Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner July 4, 2024 09:52
@randmonkey randmonkey marked this pull request as draft July 4, 2024 10:40
@randmonkey
Copy link
Contributor Author

randmonkey commented Jul 4, 2024

#6290 The logic of reference grant check may have issues, so turn it into draft before we resolve that.
The reference grant check issue is fixed, so this PR should be ready to review.

@randmonkey randmonkey force-pushed the feat/custom_entity_ref_grant branch from d5dbb66 to 2b212e7 Compare July 12, 2024 07:16
@randmonkey randmonkey marked this pull request as ready for review July 12, 2024 07:17
@randmonkey randmonkey force-pushed the feat/custom_entity_ref_grant branch from 2b212e7 to e77a603 Compare July 16, 2024 10:24
@randmonkey randmonkey merged commit 02cb949 into main Jul 17, 2024
39 checks passed
@randmonkey randmonkey deleted the feat/custom_entity_ref_grant branch July 17, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support KongCustomEntity to refer to resource in other namespace in spec.parentRef
2 participants