Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry to helm installation and knative manifests apply #523

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Feb 1, 2023

What this PR does / why we need it

This PR adds the retry package that can be used to trigger commands that should be retried in case of a failure.

Which issue does this solve

Closes #476 and #466

@pmalek pmalek added the area/feature New feature or request label Feb 1, 2023
@pmalek pmalek self-assigned this Feb 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Base: 53.33% // Head: 51.65% // Decreases project coverage by -1.69% ⚠️

Coverage data is based on head (e4d4dd6) compared to base (ad4be26).
Patch coverage: 70.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   53.33%   51.65%   -1.69%     
==========================================
  Files          49       50       +1     
  Lines        3896     3903       +7     
==========================================
- Hits         2078     2016      -62     
- Misses       1555     1641      +86     
+ Partials      263      246      -17     
Flag Coverage Δ
integration-test 56.32% <70.96%> (-1.93%) ⬇️
unit-test 3.27% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/clusters/addons/knative/knative.go 0.00% <0.00%> (-59.63%) ⬇️
pkg/clusters/cleanup.go 77.96% <ø> (ø)
pkg/clusters/addons/kong/addon.go 60.88% <71.42%> (+0.20%) ⬆️
internal/retry/command.go 100.00% <100.00%> (ø)
pkg/clusters/utils.go 50.20% <0.00%> (+1.24%) ⬆️
pkg/clusters/types/kind/cluster.go 75.00% <0.00%> (+1.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmalek pmalek marked this pull request as ready for review February 1, 2023 15:16
@pmalek pmalek requested a review from a team as a code owner February 1, 2023 15:16
@pmalek pmalek enabled auto-merge (squash) February 1, 2023 15:16
@pmalek pmalek merged commit 48f1e92 into main Feb 1, 2023
@pmalek pmalek deleted the retry branch February 1, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addons installed by helm are prone to external services errors during installation
3 participants