-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssl): add const to ngx_lua_kong_ssl_x509_copy argument #83
Conversation
@@ -303,7 +303,7 @@ ngx_lua_kong_ssl_set_upstream_ssl(ngx_lua_kong_ssl_ctx_t *ctx, ngx_connection_t | |||
|
|||
|
|||
static X509 * | |||
ngx_lua_kong_ssl_x509_copy(X509 *in) | |||
ngx_lua_kong_ssl_x509_copy(const X509 *in) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not figure out why this change did not break the Mac toolchain before.
Verified on Mac(M1) with the Bazel build. |
Do we need to compile without ignoring the warnings, as it is possible to miss warnings that are actually errors? |
@catbro666 Yes I think so. We might need the |
Fix a warning that is recently being treated as error on macOS.
KAG-4050