-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: declare peer_conn can only be used in the http subsystem #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
3 tasks
chobits
reviewed
Mar 27, 2024
chobits
approved these changes
Mar 28, 2024
dndx
requested changes
Apr 17, 2024
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
chobits
approved these changes
Apr 19, 2024
chronolaw
reviewed
Apr 19, 2024
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
chronolaw
reviewed
Apr 22, 2024
Signed-off-by: tzssangglass <tzssangglass@gmail.com>
chobits
approved these changes
Apr 23, 2024
chronolaw
approved these changes
Apr 23, 2024
dndx
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is an additional section of #82 that ensures
peer_conn
is used correctly under the http subsystem.Fix FTI-5616