Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ssl): add function to get socket ssl #86

Merged
merged 1 commit into from
Apr 19, 2024
Merged

feat(ssl): add function to get socket ssl #86

merged 1 commit into from
Apr 19, 2024

Conversation

Water-Melon
Copy link
Contributor

KAG-3791

@CLAassistant
Copy link

CLAassistant commented Apr 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch 2 times, most recently from 6d4e383 to 9d526fd Compare April 2, 2024 09:55
@Water-Melon Water-Melon marked this pull request as ready for review April 2, 2024 10:33
@AndyZhang0707 AndyZhang0707 requested a review from fffonion April 8, 2024 05:33
@fffonion
Copy link
Contributor

fffonion commented Apr 8, 2024

we need the get socket ssl instead of request ssl

@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch from 9d526fd to 1f3aa39 Compare April 8, 2024 09:57
fffonion
fffonion reviewed Apr 8, 2024
View reviewed changes
lualib/resty/kong/tls.lua Outdated Show resolved Hide resolved
@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch from 1f3aa39 to 096dffd Compare April 8, 2024 10:45
@Water-Melon Water-Melon requested a review from fffonion April 8, 2024 10:48
@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch 4 times, most recently from 04f22fe to 64d891c Compare April 9, 2024 07:12
@Water-Melon Water-Melon changed the title feat(ssl): add function to get request ssl feat(ssl): add function to get socket ssl Apr 10, 2024
fffonion
fffonion reviewed Apr 15, 2024
View reviewed changes
Copy link
Contributor

@fffonion fffonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add tests @Water-Melon

@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch 11 times, most recently from a47dee5 to a000d73 Compare April 16, 2024 02:13
oowl
oowl reviewed Apr 16, 2024
View reviewed changes
config Outdated Show resolved Hide resolved
@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch 8 times, most recently from 799283f to bd19b6b Compare April 16, 2024 09:05
@Water-Melon Water-Melon requested a review from fffonion April 16, 2024 10:00
@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch from a18b8da to fc7ea24 Compare April 16, 2024 10:32
@Water-Melon Water-Melon marked this pull request as ready for review April 16, 2024 10:32
oowl
oowl approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks！

@fffonion
Copy link
Contributor

One last piece we need is to add this function to readme.

@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch from fc7ea24 to 18dc860 Compare April 17, 2024 10:28
@Water-Melon
Copy link
Contributor Author

One last piece we need is to add this function to readme.

Thanks. README has been updated.

@ADD-SP ADD-SP force-pushed the feat/add_get_req_ssl branch from 18dc860 to 0ac6360 Compare April 18, 2024 02:26
fffonion
fffonion reviewed Apr 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch from 0ac6360 to c8d159b Compare April 18, 2024 05:55
chronolaw
chronolaw reviewed Apr 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
chronolaw
chronolaw reviewed Apr 18, 2024
View reviewed changes
lualib/resty/kong/tls.lua Outdated Show resolved Hide resolved
t/001-tls.t Show resolved Hide resolved
t/001-tls.t Outdated Show resolved Hide resolved
t/stream/003-tls.t Outdated Show resolved Hide resolved
@Water-Melon Water-Melon force-pushed the feat/add_get_req_ssl branch from c8d159b to 644389b Compare April 19, 2024 02:46
@Water-Melon Water-Melon requested a review from chronolaw April 19, 2024 03:10
@Water-Melon Water-Melon requested a review from oowl April 19, 2024 03:51
@fffonion fffonion merged commit a8411f7 into master Apr 19, 2024
6 checks passed
@fffonion fffonion deleted the feat/add_get_req_ssl branch April 19, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

@chronolaw chronolaw chronolaw approved these changes

@oowl oowl oowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Water-Melon @CLAassistant @fffonion @chronolaw @oowl