Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception!!! 'report_tcp_success()' unimplemented in healthcheck.lua #19

Closed
xiayezi2013 opened this issue May 10, 2019 · 1 comment · Fixed by #20
Closed

Exception!!! 'report_tcp_success()' unimplemented in healthcheck.lua #19

xiayezi2013 opened this issue May 10, 2019 · 1 comment · Fixed by #20

Comments

@xiayezi2013
Copy link

2019/05/10 12:23:29 [error] 12056#0: *195028 lua user thread aborted: runtime error: /usr/local/share/lua/5.1/resty/healthcheck.lua:737: attempt to call method 'report_tcp_success' (a nil value)
stack traceback:
coroutine 0:
/usr/local/share/lua/5.1/resty/healthcheck.lua: in function 'run_single_check'
/usr/local/share/lua/5.1/resty/healthcheck.lua:798: in function </usr/local/share/lua/5.1/resty/healthcheck.lua:794>
coroutine 1:
[C]: in function 'connect'
/usr/local/share/lua/5.1/resty/healthcheck.lua:726: in function 'run_single_check'
/usr/local/share/lua/5.1/resty/healthcheck.lua:798: in function 'run_work_package'
/usr/local/share/lua/5.1/resty/healthcheck.lua:826: in function 'active_check_targets'
/usr/local/share/lua/5.1/resty/healthcheck.lua:907: in function </usr/local/share/lua/5.1/resty/healthcheck.lua:871>, context: ngx.timer, client: 127.0.0.1, server: 127.0.0.1:8001
2019/05/10 12:23:29 [error] 12056#0: *195028 lua user thread aborted: runtime error: /usr/local/share/lua/5.1/resty/healthcheck.lua:737: attempt to call method 'report_tcp_success' (a nil value)
stack traceback:
coroutine 0:
/usr/local/share/lua/5.1/resty/healthcheck.lua: in function 'run_single_check'
/usr/local/share/lua/5.1/resty/healthcheck.lua:798: in function </usr/local/share/lua/5.1/resty/healthcheck.lua:794>
coroutine 1:
[C]: in function 'connect'
/usr/local/share/lua/5.1/resty/healthcheck.lua:726: in function 'run_single_check'
/usr/local/share/lua/5.1/resty/healthcheck.lua:798: in function 'run_work_package'
/usr/local/share/lua/5.1/resty/healthcheck.lua:826: in function 'active_check_targets'
/usr/local/share/lua/5.1/resty/healthcheck.lua:907: in function </usr/local/share/lua/5.1/resty/healthcheck.lua:871>, context: ngx.timer, client: 127.0.0.1, server: 127.0.0.1:8001
2019/05/10 12:23:29 [error] 12056#0: *195028 lua entry thread aborted: runtime error: /usr/local/share/lua/5.1/resty/healthcheck.lua:737: attempt to call method 'report_tcp_success' (a nil value)
stack traceback:
coroutine 0:
/usr/local/share/lua/5.1/resty/healthcheck.lua: in function 'run_single_check'
/usr/local/share/lua/5.1/resty/healthcheck.lua:798: in function 'run_work_package'
/usr/local/share/lua/5.1/resty/healthcheck.lua:826: in function 'active_check_targets'
/usr/local/share/lua/5.1/resty/healthcheck.lua:907: in function </usr/local/share/lua/5.1/resty/healthcheck.lua:871>, context: ngx.timer, client: 127.0.0.1, server: 127.0.0.1:8001
@Tieske
Copy link
Member

Tieske commented May 10, 2019

thanks for the report.

Tieske added a commit that referenced this issue May 10, 2019
@Tieske
fix(tcp) fix success reporting
5386aee 
Bad name being called and a lack of tests. 2 regression tests
for TCP added

fixes #19
@Tieske Tieske mentioned this issue May 10, 2019
Merged
hishamhm pushed a commit that referenced this issue May 10, 2019
@Tieske @hishamhm
fix(tcp) fix success reporting (#20)
f88c6f6 
Bad name being called and a lack of tests. 2 regression tests
for TCP added

fixes #19
hishamhm added a commit to Kong/kong that referenced this issue May 10, 2019
@hishamhm
tests(healthchecks) add test for success in stream active healthchecks
4e004d1 
This serves as a regression test for the problem in
Kong/lua-resty-healthcheck#19
hishamhm added a commit to Kong/kong that referenced this issue May 13, 2019
@hishamhm
tests(healthchecks) add test for success in stream active healthchecks
aa73aef 
This serves as a regression test for the problem in
Kong/lua-resty-healthcheck#19
@hishamhm hishamhm mentioned this issue May 15, 2019
Merged
hishamhm added a commit to Kong/kong that referenced this issue May 15, 2019
@hishamhm
tests(healthchecks) add test for success in stream active healthchecks
aa1099c 
This serves as a regression test for the problem in
Kong/lua-resty-healthcheck#19
hishamhm added a commit to Kong/kong that referenced this issue May 16, 2019
@hishamhm
tests(healthchecks) add test for success in stream active healthchecks
977defe 
This serves as a regression test for the problem in
Kong/lua-resty-healthcheck#19

The new tests are marked as #flaky because they are timing-dependent,
so we we will not run them regularly in CI.
hishamhm added a commit to Kong/kong that referenced this issue May 16, 2019
@hishamhm
tests(healthchecks) add test for success in stream active healthchecks
7cfbd1e 
This serves as a regression test for the problem in
Kong/lua-resty-healthcheck#19

The new tests are marked as #flaky because they are timing-dependent,
so we we will not run them regularly in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tcp) fix success reporting Kong/lua-resty-healthcheck
2 participants
@Tieske @xiayezi2013