feat(lib): remove version check of resty.events #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
feat/support_resty_events_03x
branch
from
ec1614e
to
580ae05
Compare
gszr
previously approved these changes
Jun 19, 2024
bungle
force-pushed
the
feat/support_resty_events_03x
branch
from
580ae05
to
2375c2c
Compare
bungle
changed the title
gszr
previously approved these changes
Jun 19, 2024
bungle
changed the title
bungle
force-pushed
the
feat/support_resty_events_03x
branch
from
2375c2c
to
96342f3
Compare
gszr
approved these changes
Jun 19, 2024
bungle
changed the title
bungle
force-pushed
the
feat/support_resty_events_03x
branch
from
96342f3
to
dbdce63
Compare
gszr
previously approved these changes
Jun 19, 2024
bungle
force-pushed
the
feat/support_resty_events_03x
branch
2 times, most recently
from
b8434b4
to
554406d
Compare
gszr
previously approved these changes
Jun 19, 2024
bungle
force-pushed
the
feat/support_resty_events_03x
branch
from
554406d
to
e84e0d9
Compare
locao
approved these changes
Jun 19, 2024
Perhaps with time. My conclusion is that we have lost more time to caching issues that it has ever given time back. There is always a case that someone who turns on caches doesn't seem to think about. Caching is totally unneeded on low traffic repo like this. Where full anything takes just minutes. |
gszr
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lua-resty-events is still in active development, we should support more possible versions.
KAG-4760