Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that target.ip is used when a hostname is not provided #48

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Ensure that target.ip is used when a hostname is not provided #48

merged 2 commits into from
Sep 18, 2020

Conversation

timmysilv
Copy link
Contributor

@timmysilv timmysilv commented Jul 30, 2020 •
edited
Loading

If the caller did not provide a hostname, this ensures that the remove code in the callback does not reference a nil-key in a table.

Fixes #46

@locao
Copy link
Contributor

locao commented Jul 30, 2020

Hi @timmysilv! Thanks for your submission! Could you provide an automated test for that fix, please? This way we know this issue won't ever come back.

Also, you can finish your Pull Request description with "Fix: #n", so when the PR is merged the issue is automatically considered fixed.

@timmysilv
Copy link
Contributor Author

Had some trouble with make install, patched that as well and rebased. Lmk if you'd prefer I separate this into 2 different PRs, or take some other action before this can be merged. Thanks!

@timmysilv
Copy link
Contributor Author

I'm not sure how to trigger another travis build, but the error seems irrelevant to my latest change, which was another instance of target.hostname causing a table to refer to the nil-key (this time in new()).

@timmysilv timmysilv changed the title fix bug in event_handler remove code Ensure that target.ip is used when a hostname was not provided Sep 2, 2020
@timmysilv timmysilv changed the title Ensure that target.ip is used when a hostname was not provided Ensure that target.ip is used when a hostname is not provided Sep 2, 2020
@Tieske Tieske merged commit fc5a75c into Kong:master Sep 18, 2020
Tieske pushed a commit that referenced this pull request Sep 18, 2020
@Tieske
fix(makefile) copying utils as well in make install #48
a814617
Tieske pushed a commit that referenced this pull request Sep 18, 2020
@Tieske
fix(hostname) use IP if hostname is not provided #48
31440a7
@Tieske
Copy link
Member

Tieske commented Sep 18, 2020

Thank you, merged with manually updated commits.

bungle added a commit to Kong/kong that referenced this pull request Sep 22, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
fd316a3 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
@bungle bungle mentioned this pull request Sep 22, 2020
Closed
bungle added a commit to Kong/kong that referenced this pull request Sep 27, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
ec626c6 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Sep 28, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
0161268 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Sep 30, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
a19a1ba 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Oct 6, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
cfdae51 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Oct 7, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
7a89b22 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Oct 8, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
34daf49 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Nov 6, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
759ed3b 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Dec 3, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
0a6c73b 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Dec 10, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
f9a18ad 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Dec 18, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
672891f 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Dec 22, 2020
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
17b8100 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Jan 13, 2021
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
4b33046 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Feb 2, 2021
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
2b02df0 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
bungle added a commit to Kong/kong that referenced this pull request Jun 28, 2021
@bungle
chore(deps) bump resty.healthcheck from 1.3.0 to 2.0.0
485614d 
### Summary

* BREAKING: fallback for deprecated top-level field `type` is now removed
  (deprecated since `0.5.0`) [#56](Kong/lua-resty-healthcheck#56)
* BREAKING: Bump `lua-resty-worker-events` dependency to `2.0.0`. This makes
  a lot of the APIs in this library asynchronous as the worker events `post`
  and `post_local` won't anymore call `poll` on a running worker automatically,
  for more information, see:
  https://github.com/Kong/lua-resty-worker-events#200-16-september-2020
* BREAKING: tcp_failures can no longer be 0 on http(s) checks (unless http(s)_failures
  are also set to 0) [#55](Kong/lua-resty-healthcheck#55)
* feature: Added support for https_sni [#49](Kong/lua-resty-healthcheck#49)
* fix: properly log line numbers by using tail calls [#29](Kong/lua-resty-healthcheck#29)
* fix: when not providing a hostname, use IP [#48](Kong/lua-resty-healthcheck#48)
* fix: makefile; make install
* feature: added a status version field [#54](Kong/lua-resty-healthcheck#54)
* feature: add headers for probe request [#54](Kong/lua-resty-healthcheck#54)
* fix: exit early when reloading during a probe [#47](Kong/lua-resty-healthcheck#47)
* fix: prevent target-list from being nil, due to async behaviour [#44](Kong/lua-resty-healthcheck#44)
* fix: replace timer and node-wide locks with resty-timer, to prevent interval
  skips [#59](Kong/lua-resty-healthcheck#59)
* change: added additional logging on posting events [#25](Kong/lua-resty-healthcheck#25)
* fix: do not run out of timers during init/init_worker when adding a vast
  amount of targets [#57](Kong/lua-resty-healthcheck#57)
* fix: do not call on the module table, but use a method for locks. Also in
  [#57](Kong/lua-resty-healthcheck#57)
AlinsRan pushed a commit to api7/lua-resty-healthcheck that referenced this pull request Jun 1, 2023
@AlinsRan
fix(hostname) use IP if hostname is not provided Kong#48
973cffe
@AlinsRan AlinsRan mentioned this pull request Jun 6, 2023
Merged
5 tasks
nowNick added a commit that referenced this pull request Oct 12, 2023
@nowNick
fix(hostname) use IP if hostname is not provided #48
43a18b6
@nowNick nowNick mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

checker:event_handler fails on a "remove" event
3 participants
@timmysilv @locao @Tieske