fix: omitted severity flags in docker image scan action #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pankajmouriyakong
commented
Aug 21, 2024
•
pankajmouriyakong
commented
- Update to Step "Generate docker-cis JSON report", removed severity flag as it was causing warnings "unknown severity option: unknown severity: FALSE"
- Update to Step "Inspect docker-cis report", removed severity flag as it was causing warnings "unknown severity option: unknown severity: FALSE"
- This severity flag is not being used at this point. Trivy uses this flag to restrict the scan to specific severity levels
- Because of no explicit severity flag, shared action uses value of global_enforce_build_failure env defined in our scripts
|
|
pankajmouriyakong
force-pushed
the
SEC-1173-update-trivy-flags
branch
from
ad1220d
to
56b0143
Compare
|
@pankajmouriyakong pls sign-off the commits as CLA requirement and follow comment |
saisatishkarra
requested changes
Aug 21, 2024
- Update to Step "Generate docker-cis JSON report", removed as it was causing warnings "unknown severity option: unknown severity: FALSE" - Update to Step "Inspect docker-cis report", removed severity env as it was causing warnings "unknown severity option: unknown severity: FALSE" - This severity flag is not being used at this point. Trivy uses this flag to restrict the scan to specific severity levels - Because of no explicit severity flag, shared action uses value of global_enforce_build_failure env defined in our scripts
pankajmouriyakong
force-pushed
the
SEC-1173-update-trivy-flags
branch
from
48bdaf5
to
df9f3de
Compare
saisatishkarra
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.