fix(entities-plugins): plugin form UX phase 2 [KM-61] #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumimakito
requested review from
LukeSwierlik,
QueaT-kong and
a team
as code owners
sumimakito
force-pushed
the
fix/KM-61-plugin-form-ux-phase-2
branch
3 times, most recently
from
a1c79fc to
004f6b5
Compare
sumimakito
force-pushed
the
fix/KM-61-plugin-form-ux-phase-2
branch
from
004f6b5 to
c5a972c
Compare
sumimakito
force-pushed
the
fix/KM-61-plugin-form-ux-phase-2
branch
from
e698011 to
5fa1cc5
Compare
Leopoldthecoder
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Manually tested in https://pr-2846--gateway-manager.cloud-preview.konghq.tech/gateway-manager and LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjusted the look and feel of field groups in the plugin form to match the Figma design
Added field rules to plugin metadata
Added alerts for field rules
proxy-cache-advanced
ip-restriction
forward-proxy
Re-organized and exported plugin metadata and several almost-constants instead of embedding them inside the composables
[Fix] Reverted fix(entities-plugins): revert the changes on the required field #1249 and added
no-validateto<EntityBaseForm />to fix some issues withproxy-cache-advancedandresponse-ratelimiting[Fix] Hid fields with
.hidden-fieldBefore
After
[Fix] Fixed some typos
KM-61