Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(entities-plugins): revert the changes on the required field #1249

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix(entities-plugins): revert the changes on the required field #1249

merged 2 commits into from
Mar 15, 2024

Conversation

sumimakito
Copy link
Member

Summary

Revert changes on the required field introduced by #1224

Tries to fix the regression caught in https://github.com/Kong/konnect-ui-apps/actions/runs/8292322240/job/22693574891?pr=2669

@sumimakito sumimakito requested review from a team as code owners March 15, 2024 08:33
@sumimakito sumimakito enabled auto-merge (squash) March 15, 2024 08:33
@sumimakito sumimakito marked this pull request as draft March 15, 2024 08:45
auto-merge was automatically disabled March 15, 2024 08:45

Pull request was converted to draft

@sumimakito sumimakito marked this pull request as ready for review March 15, 2024 09:00
@sumimakito sumimakito enabled auto-merge (squash) March 15, 2024 09:01
@sumimakito sumimakito merged commit 755fe82 into main Mar 15, 2024
7 checks passed
@sumimakito sumimakito deleted the fix/forms-required branch March 15, 2024 09:39
@sumimakito sumimakito mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumimakito @Leopoldthecoder