Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities): form data-testid changes [khcp-13000] #1565

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

kaiarrowood
Copy link
Contributor

@kaiarrowood kaiarrowood commented Aug 16, 2024

Summary

Update entity data-testid to be more specific for analytics tracking.
Addresses KHCP-13000.

Adoption PR (with passing e2e's): https://github.com/Kong/konnect-ui-apps/pull/3995

Resources

@kaiarrowood kaiarrowood self-assigned this Aug 16, 2024
@kaiarrowood kaiarrowood changed the title fix(*): entity-base-form changes [khcp-13000] fix(entities): entity-base-form changes [khcp-13000] Aug 19, 2024
@kaiarrowood kaiarrowood changed the title fix(entities): entity-base-form changes [khcp-13000] fix(entities): form data-testid changes [khcp-13000] Aug 19, 2024
@kaiarrowood kaiarrowood marked this pull request as ready for review August 20, 2024 17:58
@kaiarrowood kaiarrowood requested review from a team as code owners August 20, 2024 17:58
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll update KM tests after new packages are released.

@kaiarrowood kaiarrowood merged commit 8959349 into main Aug 21, 2024
21 checks passed
@kaiarrowood kaiarrowood deleted the feat/khcp-13000-entity-data-testids branch August 21, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants