fix: more vite.config cleanups #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdehaven
reviewed
Aug 29, 2024
adamdehaven
reviewed
Aug 29, 2024
Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com>
Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com>
adamdehaven
approved these changes
Sep 3, 2024
adamdehaven
added a commit
that referenced
this pull request
Sep 4, 2024
* feat(entities-certificates): externalize deps * refactor: use regular expression for package match * refactor: use regular expression for package match * fix(deps): externalize for all packages * fix(rollup): externalize * fix: package.json * fix(deps): use workspace version * fix: lockfile * fix: external dep pattern match * fix: externals * chore: exclude styles * chore: remove duplicate entries covered by root config * fix: do not externalize styles * fix: more vite.config cleanups (#1589) * fix: more vite.config cleanups * Update packages/entities/entities-routes/vite.config.ts Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com> * Update packages/analytics/analytics-geo-map/vite.config.ts Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com> * Update vite.config.ts * Update vite.config.ts --------- Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com> --------- Co-authored-by: ValeryG <vvalggor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
removing more entities covered in shared