Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): adopt native mask support #1716

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix(forms): adopt native mask support #1716

merged 1 commit into from
Oct 15, 2024

Conversation

Leopoldthecoder
Copy link
Member

Summary

Now KInput supports toggling password input mask natively through Kong/kongponents#2448. This PR adopts this feature.

KM-586

Justineo
Justineo approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Justineo Justineo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 31fb12a into main Oct 15, 2024
12 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/native-mask branch October 15, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TT1228 TT1228 TT1228 approved these changes

@Justineo Justineo Justineo approved these changes

@LukeSwierlik LukeSwierlik Awaiting requested review from LukeSwierlik LukeSwierlik is a code owner

@QueaT-kong QueaT-kong Awaiting requested review from QueaT-kong QueaT-kong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leopoldthecoder @Justineo @TT1228