Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-plugins): ai-proxy-advanced form #1769

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Nov 6, 2024

Summary

This is a temporary workaround for the issue that the ai-proxy-advanced plugin cannot be created if users don't provide config.embeddings or config.vectordb.

KM-675

@Leopoldthecoder Leopoldthecoder requested review from a team as code owners November 6, 2024 07:43
@Leopoldthecoder Leopoldthecoder marked this pull request as draft November 6, 2024 07:43
@Leopoldthecoder Leopoldthecoder force-pushed the fix/ai-proxy-advanced-form branch from 49f933b to ece4426 Compare November 6, 2024 09:28
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review November 8, 2024 06:43
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and the submission via the button worked as expected.

One more thing: Would we want to keep the model shown in View Configuration consistent with the final payload that will be submitted by us?

Configuration Request payload
Screenshot 2024-11-08 at 14 46 53 Screenshot 2024-11-08 at 14 50 22

@Leopoldthecoder
Copy link
Member Author

Ideally yes, we should keep them consistent. But it is not easy to do given the current implementation, as we are copying the payload so that it can be transformed. Will revisit if necessary.

@Leopoldthecoder Leopoldthecoder merged commit 0485ca2 into main Nov 8, 2024
9 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/ai-proxy-advanced-form branch November 8, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants