feat(plugin-form): disable scoped plugin toggle #1816
Conversation
TT1228
requested review from
LukeSwierlik,
QueaT-kong and
a team
as code owners
| @@ -99,6 +114,9 @@ export default { | |||
| entity() { | |||
| return this.schema.entity | |||
| }, | |||
| scope() { | |||
| return this.entity.replace('_',' ').replace(/s$/,'') | |||
There was a problem hiding this comment.
What if we add some entity with three words in the name, or the name ends with y? I think it's clearer to create a string mapping instead.
There was a problem hiding this comment.
On a second thought, should the scope value also be an i18n key? Maybe we can use entity as that key directly?
| v-for="(option, i) in schema.fields" | ||
| :key="i" | ||
| class="option-group" | ||
| :class="{ 'radio-diabled': $props.disabled }" |
There was a problem hiding this comment.
| :class="{ 'radio-diabled': $props.disabled }" | |
| :class="{ 'radio-disabled': $props.disabled }" |
| @@ -157,6 +178,16 @@ export default { | |||
| flex-direction: row; | |||
| gap: $kui-space-80; | |||
| } | |||
|
|
|||
| .radio-diabled { | |||
There was a problem hiding this comment.
| .radio-diabled { | |
| .radio-disabled { |
|
|
||
| input { | ||
| cursor: not-allowed; | ||
| } |
There was a problem hiding this comment.
We can group the above rulesets.
| @@ -443,7 +443,8 @@ const defaultFormSchema: DefaultPluginsSchemaRecord = reactive({ | |||
| }, | |||
| // plugin scoping | |||
| selectionGroup: { | |||
| type: !props.hideScopeSelection ? 'selectionGroup' : props.hideScopeSelection || (formType.value === EntityBaseFormType.Create && props.config.entityId) ? 'foreign' : 'selectionGroup', | |||
| type: 'selectionGroup', | |||
| disabled: !props.hideScopeSelection ? false : props.hideScopeSelection || (formType.value === EntityBaseFormType.Create && props.config.entityId) ? true : false, | |||
There was a problem hiding this comment.
Let's reverse the condition for better readability.
There was a problem hiding this comment.
Good point. When i copied those code, i already found it weird that || (formType.value === EntityBaseFormType.Create && props.config.entityId) is totally not working
TT1228
force-pushed
the
feat/KM-621-new-scoped-plugin-behavior
branch
from
fb59b8f to
5b29f32
Compare
|
Note: let's merge this PR after 3.9 code freeze. |
TT1228
force-pushed
the
feat/KM-621-new-scoped-plugin-behavior
branch
from
5b29f32 to
51d0701
Compare
TT1228
force-pushed
the
feat/KM-621-new-scoped-plugin-behavior
branch
from
51d0701 to
2c2d9bf
Compare
Summary
KM-621
Instead of hiding scope selection group under scoped plugin, the source scope is fixed and global/scoped checkbox group is greyed out with explanation(by passing a new prop
disableScopeSelection). This keeps UI consistency and provide easier configuration of scoped plugins.Slack: https://kongstrong.slack.com/archives/C03NRECFJPM/p1732126368893859?thread_ts=1729624945.925459&cid=C03NRECFJPM
KM
disableScopeSelectionis not passed,hideScopeSelectionis kept.KM Dev Portal
GM
hideScopeSelectionis replaced bydisableScopeSelection.GM preview link: https://pr-5021--gateway-manager.cloud-preview.konghq.tech/gateway-manager