Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): handle missing fields in span #1856

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(tracing): handle missing fields in span #1856

merged 1 commit into from
Dec 18, 2024

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Dec 17, 2024 •
edited
Loading

Summary

Screenshot 2024-12-18 at 10 43 11
  • Marking some fields as optional as they might be missing in real-world use cases
  • Better handling of these cases and showing an icon to indicate the span is potentially malformed
  • Providing an alert in the span detail pane when the span is potentially malformed
  • Type and misc fixes

KM-824

@sumimakito sumimakito requested review from a team as code owners December 17, 2024 16:11
@sumimakito sumimakito force-pushed the KM-824-tracing-missing-fields branch 2 times, most recently from 2351139 to 957b61f Compare December 18, 2024 04:08
Leopoldthecoder
Leopoldthecoder previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumimakito sumimakito force-pushed the KM-824-tracing-missing-fields branch from 957b61f to 389fadc Compare December 18, 2024 06:19
Leopoldthecoder
Leopoldthecoder approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumimakito sumimakito merged commit b9e11d9 into main Dec 18, 2024
9 checks passed
@sumimakito sumimakito deleted the KM-824-tracing-missing-fields branch December 18, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumimakito @Leopoldthecoder