Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): check i18n key in a better way #1869

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(tracing): check i18n key in a better way #1869

merged 1 commit into from
Dec 20, 2024

Conversation

sumimakito
Copy link
Member

Summary

This pull request updates the logic to check the availability of an i18n key to avoid printing errors in the console:

Screenshot 2024-12-20 at 14 44 20

@sumimakito sumimakito requested review from a team as code owners December 20, 2024 06:47
Leopoldthecoder
Leopoldthecoder approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumimakito sumimakito merged commit 2f3ff76 into main Dec 20, 2024
9 checks passed
@sumimakito sumimakito deleted the fix/better-check-i18n-key branch December 20, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumimakito @Leopoldthecoder