-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugins): plugin select unification [khcp-9487] #870
Conversation
ca12941
to
d4c547a
Compare
packages/entities/entities-shared/src/composables/useHelpers.ts
Outdated
Show resolved
Hide resolved
packages/entities/entities-shared/src/composables/useHelpers.ts
Outdated
Show resolved
Hide resolved
packages/entities/entities-shared/src/composables/useHelpers.ts
Outdated
Show resolved
Hide resolved
display: flex; | ||
flex-basis: 100%; | ||
flex-flow: row-wrap; | ||
max-width: 335px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why this specific max-width?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use CSS grid to handle the size instead of flex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time to refactor the CSS right now and this isn't something I know how to do off the top of my head. Could it be a ticket for the backlog?
packages/entities/entities-plugins/src/components/PluginSelectGrid.vue
Outdated
Show resolved
Hide resolved
packages/entities/entities-plugins/src/components/PluginSelectGrid.vue
Outdated
Show resolved
Hide resolved
packages/entities/entities-shared/src/composables/useHelpers.ts
Outdated
Show resolved
Hide resolved
packages/entities/entities-shared/src/composables/useHelpers.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com>
0cb8885
to
3e2fd2c
Compare
Summary
Unification for the
Plugins
->Select
page. For KHCP-9487.PR Checklist