Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): plugin select unification [khcp-9487] #870

Merged
merged 40 commits into from
Nov 1, 2023

Conversation

kaiarrowood
Copy link
Contributor

@kaiarrowood kaiarrowood commented Oct 26, 2023

Summary

Unification for the Plugins -> Select page. For KHCP-9487.

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@kaiarrowood kaiarrowood self-assigned this Oct 26, 2023
@kaiarrowood kaiarrowood force-pushed the feat/khcp-9487-unification-plugin-form branch from ca12941 to d4c547a Compare October 27, 2023 21:42
packages/entities/entities-plugins/docs/plugin-select.md Outdated Show resolved Hide resolved
packages/entities/entities-plugins/docs/plugin-select.md Outdated Show resolved Hide resolved
display: flex;
flex-basis: 100%;
flex-flow: row-wrap;
max-width: 335px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why this specific max-width?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we don't want the cards themselves to be resizing based on the space available. This is the width that seems to look best for the design?

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use CSS grid to handle the size instead of flex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have time to refactor the CSS right now and this isn't something I know how to do off the top of my head. Could it be a ticket for the backlog?

@Leopoldthecoder
Copy link
Member

Can we adjust the size of skeletons so they align with the size of actual plugin cards? Right now they are a lot bigger. Also I think the divider can be moved up a little, and its color can be lighter.

image

@kaiarrowood kaiarrowood force-pushed the feat/khcp-9487-unification-plugin-form branch from 0cb8885 to 3e2fd2c Compare November 1, 2023 14:27
@kaiarrowood kaiarrowood marked this pull request as ready for review November 1, 2023 14:29
@kaiarrowood kaiarrowood requested review from kongponents-bot and a team as code owners November 1, 2023 14:29
@kaiarrowood kaiarrowood merged commit c9c155e into main Nov 1, 2023
28 checks passed
@kaiarrowood kaiarrowood deleted the feat/khcp-9487-unification-plugin-form branch November 1, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants