Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin/form): schema hint propagation #939

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

kaiarrowood
Copy link
Contributor

@kaiarrowood kaiarrowood commented Nov 22, 2023

Summary

Fix hint text in custom schemas not being respected.

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@kaiarrowood kaiarrowood self-assigned this Nov 22, 2023
@kaiarrowood kaiarrowood requested review from a team as code owners November 22, 2023 21:07
Copy link
Contributor

@DariaYeremina DariaYeremina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiarrowood kaiarrowood enabled auto-merge (squash) November 22, 2023 21:10
@kaiarrowood kaiarrowood merged commit 4ff96cc into main Nov 22, 2023
5 checks passed
@kaiarrowood kaiarrowood deleted the fix/plugin-form-schema-hint branch November 22, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants