Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shading warnings #323

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Fix shading warnings #323

merged 2 commits into from
Aug 12, 2021

Conversation

ThexXTURBOXx
Copy link
Contributor

@ThexXTURBOXx ThexXTURBOXx commented Jul 17, 2021 •
edited
Loading

This PR fixes all the duplicated classes and files in the shading process.

Bugs are to be expected and need to be pinpointed down to their core. Many libraries have weak encapsulation and depend on specific versions of other libraries. Changing these versions (like this PR does) can lead to major bugs. Please test thoroughly!

Edit: Also, the size of BCV now went up to ~ 45 MB because of ANTLR v4 including some library from IBM. If you want to shrink BCV, you should try removing it. I don't know if it is really needed

@ThexXTURBOXx ThexXTURBOXx force-pushed the master branch 2 times, most recently from b264675 to fc41f3e Compare July 19, 2021 19:49
@ThexXTURBOXx ThexXTURBOXx changed the title Fix shading warnings [Draft] Fix shading warnings Jul 20, 2021
@ThexXTURBOXx ThexXTURBOXx marked this pull request as draft July 20, 2021 16:07
@ThexXTURBOXx ThexXTURBOXx force-pushed the master branch 2 times, most recently from 17dc252 to 8317df8 Compare July 21, 2021 11:37
@ThexXTURBOXx ThexXTURBOXx mentioned this pull request Aug 9, 2021
Merged
@ThexXTURBOXx
Copy link
Contributor Author

I have updated this PR according to the new version of Dex2Jar. The only issue remaining is the big library ICU4J from IBM, which is added by ANTLR4. I am unsure how to address this, though.

@ThexXTURBOXx
Copy link
Contributor Author

I just excluded ICU4J now manually. I don't know if this is the right approach, but it still works on my Windows machine.
If any issues arise, we may need to add this again, but for now, I would say that this PR is stable and can get merged.
The binary size of BytecodeViewer is now ~36 MB as opposed to ~34.5 MB before, which is not too bad

@ThexXTURBOXx ThexXTURBOXx marked this pull request as ready for review August 10, 2021 09:29
@ThexXTURBOXx ThexXTURBOXx changed the title [Draft] Fix shading warnings Fix shading warnings Aug 12, 2021
@ThexXTURBOXx ThexXTURBOXx mentioned this pull request Aug 12, 2021
Merged
@Konloch Konloch merged commit bee442e into Konloch:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThexXTURBOXx @Konloch