Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #340

Merged
merged 8 commits into from
Aug 7, 2021
Merged

Updates #340

merged 8 commits into from
Aug 7, 2021

Conversation

ThexXTURBOXx
Copy link
Contributor

@ThexXTURBOXx ThexXTURBOXx commented Aug 1, 2021

This PR fixes the following issues:

  • Update Janino
  • Update DarkLaf to stable 2.7.1 release
  • Force Antialiasing at the manually rendered class/jar/... text
  • Fix the file drop that I accidentally broke at some point (oops)

Actually, it's a snapshot for now. 2.7.0 still has the Java 8 issue that causes the text to be blocky. 2.7.1 will fix this issue entirely and will support Java 16 completely.
@ThexXTURBOXx ThexXTURBOXx marked this pull request as ready for review August 1, 2021 11:47
@ThexXTURBOXx
Copy link
Contributor Author

ThexXTURBOXx commented Aug 1, 2021

Updated DarkLaf to stable 2.7.1. Every known issue is fixed now and this PR is ready to get merged.

@ThexXTURBOXx
Copy link
Contributor Author

Addendum: CI/CD keeps failing because of weisJ/darklaf#257. We will need to wait a little bit more until DarkLaf doesn't depend on a snapshot anymore.

@ThexXTURBOXx ThexXTURBOXx marked this pull request as draft August 1, 2021 11:54
If the CI/CD approves, this will be the real stable release
@ThexXTURBOXx ThexXTURBOXx marked this pull request as ready for review August 1, 2021 12:52
@ThexXTURBOXx
Copy link
Contributor Author

Forgot to comment about the new commit:
DarkLaf 2.7.2 fixed the last issue as well. Now, everything seems to be stable and working correctly.
Finally really ready to get merged!

This doesn't fix any issue, but may be useful in some cases, I guess?
@Konloch Konloch merged commit bc19b3b into Konloch:master Aug 7, 2021
@Konloch
Copy link
Owner

Konloch commented Aug 7, 2021

Thank you!

@ThexXTURBOXx ThexXTURBOXx deleted the updates branch August 8, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants