Small UI fixes. #415
Merged
Small UI fixes. #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/the/bytecode/club/bytecodeviewer/searching/impl/LDCSearch.java # src/main/java/the/bytecode/club/bytecodeviewer/searching/impl/MemberWithAnnotationSearch.java # src/main/java/the/bytecode/club/bytecodeviewer/searching/impl/MethodCallSearch.java # src/main/java/the/bytecode/club/bytecodeviewer/searching/impl/RegexSearch.java
weisJ
reviewed
Apr 17, 2022
Comment on lines
184
to
188
| LafManager.registerInitTask((t, p) -> SwingUtilities.invokeLater(() -> { | ||
| for (Component component : components) | ||
| SwingUtilities.updateComponentTreeUI(component); | ||
| })); | ||
| } |
There was a problem hiding this comment.
I suggest to use
for (var comp : components) {
UIUpdater.registerComponent(comp);
}instead. The fact that you have to run the ui update logic in invokeLater comes from the fact that when the init task is called the complete Laf hasn't been yet installed completely. It also has the advantage of not preventing the component from being garbage collected.
There was a problem hiding this comment.
Thank you. I was looking for that, but couldn't find any documentation.
|
Thank you! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Had to merge master as i forgot to update my repo, but it should work)