-
-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Maintain selections when editor blurred, and fix file uploads on race…
… conditions (#227) * maintain link selection when focus changes * add fake link selection * make attachment-upload re-fetch objects * prettier * finishing up direct upload stuff * prettier * add fake cursor * add note about fake selections * Add note to events about stopping form submissions on pending uploads * add chnagelog entry * fix css * update changelog * fix ff tests * fix css * fix css * add prettierignore
- Loading branch information
1 parent
480849b
commit 924d0ff
Showing
24 changed files
with
848 additions
and
228 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"rhino-editor": minor | ||
--- | ||
|
||
Added a "faux selection" for link insertions to give a visual indicator of insertion / replacement points for links. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"rhino-editor": patch | ||
--- | ||
|
||
Fixed a bug around "progress" finishing prematurely |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"rhino-editor": minor | ||
--- | ||
|
||
Add a `rhino-editor.css` which is a more minimal `trix.css` and has no styles on the editor content. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"rhino-editor": patch | ||
--- | ||
|
||
Fixed a bug with direct upload events not dispatching under the proper name |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
src/exports/styles/trix.css | ||
src/exports/styles/rhino-editor.css |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
--- | ||
title: Fake Selections and Insertions | ||
permalink: /references/fake-selections/ | ||
--- | ||
|
||
Rhino Editor has a couple of utilities for having "fake" insertions and selections. | ||
|
||
You'll notice as of v0.14.0 when you move focus to the link dialog inputs, the editor will either show a fake insertion cursor, or show a fake selection "box" around the currently selected text. | ||
|
||
There's also a fake cursor used for inline code blocks courtesy of the [Codemark Plugin](https://github.com/curvenote/editor/tree/main/packages/prosemirror-codemark) | ||
|
||
The CSS for these fake selections comes directly from `"rhino-editor/exports/styles/trix.css"`. | ||
|
||
However, some people may not use this because it can be overly opinionated. Fake selections / cursors can also be added to a CSS file via: | ||
|
||
`@import "rhino-editor/exports/styles/rhino-editor.css"` | ||
|
||
or from a JavaScript file: | ||
|
||
`import "rhino-editor/exports/styles/rhino-editor.css"` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.