Skip to content
This repository has been archived by the owner on Jul 13, 2020. It is now read-only.

Add start and end rules to RelativeLayout.LayoutParams extensions. #497

Merged

Conversation

jimmy-robert
Copy link
Contributor

No description provided.

jimmy-robert pushed a commit to jimmy-robert/Kola that referenced this pull request Oct 28, 2017
@4u7 4u7 self-assigned this Nov 8, 2017
@4u7 4u7 self-requested a review November 8, 2017 21:45
@4u7
Copy link
Contributor

4u7 commented Nov 8, 2017

Thanks for contribution!
Why not to use constants instead of int literals?
And I think those methods should be annotated with @RequiresApi(Build.VERSION_CODES.JELLY_BEAN_MR1)

@jimmy-robert
Copy link
Contributor Author

Thanks for the review.

I did use constants first but I saw that existing functions alignParentStart and alignParentEnd were using int literals.

I agree that it would be better with constants and with @RequestApi annotation.

I will update the PR with these modifications asap.

@jimmy-robert
Copy link
Contributor Author

@4u7 PR updated with recommandations.

@4u7 4u7 merged commit c75276c into Kotlin:master Nov 9, 2017
@4u7
Copy link
Contributor

4u7 commented Nov 9, 2017

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants