Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KlibSignatureVersion.LATEST.toString() is rendered as KlibSignatureVersion(-2147483648) #219

Closed
aSemy opened this issue Apr 15, 2024 · 0 comments · Fixed by #220
Closed

KlibSignatureVersion.LATEST.toString() is rendered as KlibSignatureVersion(-2147483648) #219

aSemy opened this issue Apr 15, 2024 · 0 comments · Fixed by #220
Assignees
@fzhinkin
Labels
enhancement New feature or request klib

Comments

@aSemy
Copy link
Contributor

aSemy commented Apr 15, 2024

println(KlibSignatureVersion.LATEST.toString()) prints KlibSignatureVersion(-2147483648).

It's strange seeing a large negative number in the version.

It would be nicer if the latest version was rendered something like KlibSignatureVersion(LATEST).
@fzhinkin fzhinkin self-assigned this Apr 22, 2024
@fzhinkin fzhinkin added enhancement New feature or request klib labels Apr 22, 2024
fzhinkin added a commit that referenced this issue Apr 22, 2024
@fzhinkin
Improve KlibSignatureVersion.toString format for LATEST version
9a96e95 
Closes #219
@fzhinkin fzhinkin mentioned this issue Apr 22, 2024
Merged
@fzhinkin fzhinkin linked a pull request Apr 22, 2024 that will close this issue
Improve KlibSignatureVersion.toString format for LATEST version #220
Merged
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Oct 28, 2024
@fzhinkin @shanshin
[ABI Validation] Improve KlibSignatureVersion.toString format for LAT…
9ebd1ea 
…EST version

Closes Kotlin/binary-compatibility-validator#219
Pull request Kotlin/binary-compatibility-validator#220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzhinkin fzhinkin

Labels
enhancement New feature or request klib
Projects
None yet
Milestone
No milestone
2 participants
@aSemy @fzhinkin