Stop supporting case insensitive file names #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filename case mismatch is no longer tolerated on case-sensitive filesystems. Fixes #231
shanshin
approved these changes
Jun 5, 2024
| @@ -41,43 +38,17 @@ public open class KotlinApiCompareTask @Inject constructor(private val objects: | |||
| } | |||
| val subject = projectName | |||
|
|
|||
| /* | |||
| @@ -90,7 +93,9 @@ internal class DefaultConfigTests : BaseKotlinGradleTest() { | |||
| } | |||
|
|
|||
| @Test | |||
| fun `apiCheck should succeed when public classes match api file ignoring case`() { | |||
| fun `apiCheck should fail when public classes match api file ignoring case`() { | |||
| Assume.assumeTrue(underlyingFsIsCaseSensitive()) | |||
There was a problem hiding this comment.
Are the tests run on different systems at once?
There was a problem hiding this comment.
They are running on Windows/Linux/MacOS from time to time, yes.
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
Filename case mismatch is no longer tolerated on case-sensitive filesystems. Fixes Kotlin/binary-compatibility-validator#231 Pull request Kotlin/binary-compatibility-validator#237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes only behaviour, task's API will be cleaned up in #204.
Fixes #231