Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable use of other ArrowReader implementations #627

Closed
fb64 opened this issue Mar 16, 2024 · 2 comments
Closed

Enable use of other ArrowReader implementations #627

fb64 opened this issue Mar 16, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone
0.14.0

Comments

@fb64
Copy link
Contributor

fb64 commented Mar 16, 2024

Some librairies or framework (DuckDB for example) rely on ArrowArrayStreamReader to share Arrow data. It would be nice to be more permissive and let any implementation of any ArrowReader works for reading arrow data
fb64 added a commit to fb64/dataframe that referenced this issue Mar 16, 2024
@fb64
Allow any ArrowReader implementation to be use for reading Arrow data
8ca2ed0 
Kotlin#627
@Jolanrensen Jolanrensen added enhancement New feature or request invalid This issue/PR doesn't seem right labels Mar 18, 2024
@Jolanrensen Jolanrensen modified the milestones: 0.13.+, 0.14.0 Mar 18, 2024
@Jolanrensen
Copy link
Collaborator

Sounds like a good idea! We might need a test with an ArrowArrayStreamReader though, to make sure it works as expected.

fb64 added a commit to fb64/dataframe that referenced this issue Mar 18, 2024
@fb64
Allow any ArrowReader implementation to be use for reading Arrow data
2457bf8 
Kotlin#627
fb64 added a commit to fb64/dataframe that referenced this issue Mar 18, 2024
@fb64
Allow any ArrowReader implementation to be use for reading Arrow data
67df4a3 
Kotlin#627
@fb64
Copy link
Contributor Author

fb64 commented Mar 18, 2024

I finally added a test with DuckDB that uses ArrowArrayStreamReader

fb64 added a commit to fb64/dataframe that referenced this issue Mar 18, 2024
@fb64
Allow any ArrowReader implementation to be use for reading Arrow data
7df9251 
Kotlin#627
fb64 added a commit to fb64/dataframe that referenced this issue Mar 25, 2024
@fb64
Allow any ArrowReader implementation to be use for reading Arrow data
b6ab5ea 
Kotlin#627
fb64 added a commit to fb64/dataframe that referenced this issue Apr 2, 2024
@fb64
Allow any ArrowReader implementation to be use for reading Arrow data
e85ec1d 
Kotlin#627
fb64 added a commit to fb64/dataframe that referenced this issue Apr 3, 2024
@fb64
Allow any ArrowReader implementation to be use for reading Arrow data
56d27e6 
Kotlin#627
Jolanrensen added a commit that referenced this issue Apr 3, 2024
@Jolanrensen
Merge pull request #628 from fb64/improve-arrow-reading
2e1986b 
Allow any ArrowReader implementation to be use for reading Arrow data #627
@zaleslaw zaleslaw removed the invalid This issue/PR doesn't seem right label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
3 participants
@zaleslaw @fb64 @Jolanrensen