-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
☂ type: KType
in DataColumnImpl
mismatches actual values sometimes
#713
Comments
7/15 tests are fixed by #727 Next are the pivot tests with |
After merging #734 there are just 5 failing tests left: |
Maybe we could use https://github.com/gmazzo/gradle-buildconfig-plugin to set a DEBUG flag and check these types when running tests |
…enabled. Updated contribution guide too. TC will have to be updated manually
#796 adds the ability to set |
@zaleslaw After #796 is merged, I´d recommend running the JDBC tests again in debug mode. I now have 15 failing tests just from that module. They contain all sorts of Char/String, Double/Float, and Int/Short mismatches. These will most likely result in runtime exceptions on the user's side if left untreated. |
One of the tests triggeres in Edit: fixed by #800 |
…-nullable column with nulls in it. This is now avoided and the behavior has been simplified/stabilized
…enabled. Updated contribution guide too. TC will have to be updated manually
…ary non-nullable column with nulls in it. This is now avoided and the behavior has been simplified/stabilized
…rary column was created with nulls in a FrameColumn
The last two main tests are fixed by #801 and #803. To solve this issue, we just need to:
|
Please, @Jolanrensen, create a ticket with the list of these JDBC tests, include in 0.14 milestone and assign on me |
Attempt to work with Conclusion: this is not an option. It also runs when DataFrame is used in a user-project test. |
type: KType
in DataColumnImpl
mismatches actual values sometimestype: KType
in DataColumnImpl
mismatches actual values sometimes
Debug mode is now enabled on TeamCity! Thanks for the help fixing the issues @zaleslaw :) |
type: KType
inDataColumnImpl
mismatches actual values in some cases. This can result in runtime exceptions and makes life difficult attempting to fix #30 or #704 where we assume thetype
always correctly represents the data.This issue relates to #701 as well.
To discover these bugs, we can introduce a (debug-only!!) check in
DataColumnImpl
, like:At the moment of testing, I can find 8+ breaking tests in
:core
:org.jetbrains.kotlinx.dataframe.io.PlaylistJsonTest#aggregate by column
[DataFrameImpl]
,kType
is:org.jetbrains.kotlinx.dataframe.aggregation.AggregateGroupedDsl<org.jetbrains.kotlinx.dataframe.io.PlaylistJsonTest.DataFrameType1>
AggregateGroupedDsl
is aDataFrame
org.jetbrains.kotlinx.dataframe.samples.api.Analyze#pivotDefault_accessors
/#pivotDefault_strings
/#pivotDefault_properties
[Boolean, Int]
,kType
is:kotlin.Boolean
concatImpl
I thinkorg.jetbrains.kotlinx.dataframe.samples.api.Modify#customConverters
[Nothing?]
,kType
iskotlin.Int
convertToImpl$convertToSchema
org.jetbrains.kotlinx.dataframe.samples.api.Modify#implode
[DataFrameImpl, Nothing?]
,kType
is:org.jetbrains.kotlinx.dataframe.DataFrame<*>
, not nullableimplodeImpl
where anull
is put in aFrameColumn
org.jetbrains.kotlinx.dataframe.testSets.person.DataFrameTests#convertTo
[Nothing?]
,kType
is:kotlin.Int
convertToImpl$convertToSchema
tooorg.jetbrains.kotlinx.dataframe.testSets.person.DataFrameTreeTests#merge rows into table
[DataFrameImpl, Nothing?]
,kType
is:org.jetbrains.kotlinx.dataframe.DataFrame<*>
, not nullableimplodeImpl
too where anull
is put in aFrameColumn
Edit: running it afresh (clean pull of master with check) I get 15 failing tests.
There is also an exception in
:dataframe-jdbc
: #701The text was updated successfully, but these errors were encountered: