Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort grouped df #204

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Sort grouped df #204

merged 4 commits into from
Dec 9, 2022

Conversation

Jolanrensen
Copy link
Collaborator

Work in progress fix for #161.
The first example is now fixed, but for the second example, I might need some test data to be sure it now works as expected.

@Jolanrensen Jolanrensen added the bug Something isn't working label Dec 8, 2022
@Jolanrensen Jolanrensen added this to the 0.9.0 milestone Dec 8, 2022
@Jolanrensen Jolanrensen self-assigned this Dec 8, 2022
@Jolanrensen
Copy link
Collaborator Author

Thanks to @koperagen the other example from the issue is now also tested and appears to be working correctly

fun KSDeclaration.getQualifiedNameOrThrow(): String {
return (qualifiedName ?: error("@DataSchema declaration ${simpleName.asString()} at $location must have qualified name")).asString()
}
fun KSDeclaration.getQualifiedNameOrThrow(): String =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this commit merged already? is it intentional or something strange happened?

Copy link
Collaborator Author

@Jolanrensen Jolanrensen Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh you're right. That's odd. I'll do another rebase and check again

@Jolanrensen
Copy link
Collaborator Author

okay now I really messed it up

@Jolanrensen Jolanrensen reopened this Dec 9, 2022
@Jolanrensen Jolanrensen merged commit b59cfb6 into master Dec 9, 2022
@Jolanrensen Jolanrensen deleted the sort-grouped-df branch December 9, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants