-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type mapping rewriting for JDBC integration #505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding JDBC connections in readJdbc.kt. In this commit, the ports in the JDBC URLs in imdbTest.kt file were modified to ensure correct connection to database servers. A new URL constant was added to facilitate reading tables with schema. A new test case was added for better testing of reading tables with schemas. In readJdbc.kt, the logic for fetching and converting data from the ResultSet was revised for better dataframe creation.
koperagen
requested changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss column types nullability before merging
Jolanrensen
reviewed
Dec 11, 2023
dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/readJdbc.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
No description provided.